Charles Wilson wrote:
2008-04-25 Charles Wilson <...>
Ensure cwrapper compiles without warnings under -std=c99:
* libltdl/config/ltmain.m4sh (func_emit_wrapper_part1):
new function.
(func_emit_wrapper_part2): new function.
(func_emit_wrapper): delegate to new functions.
(func_emit_cwrapperexe_src) [__CYGWIN__ && __STRICT_ANSI__]:
ensure realpath is declared.
(func_emit_cwrapperexe_src): declare two different strings
to each hold part of the wrapper script content. Initialize
using new func_emit_wrapper_partX functions.
(func_emit_cwrapperexe_src) [main]: when emitting wrapper
script content, use both strings.
However, this bit in the posted patch, in func_emit_wrapper():
+ func_emit_wrapper_part1 "${func_emit_wrapper_arg1}"
+ func_emit_wrapper_part2 "${func_emit_wrapper_arg2}"
should really be
+ func_emit_wrapper_part1 "${func_emit_wrapper_arg1}"
+ func_emit_wrapper_part2 "${func_emit_wrapper_arg1}"
because func_emit_wrapper() only has *arg1 and should pass that argument
on to both of the func_emit_wrapper_part*() sub-functions.
Okay for push, with the above change and rebasing?
BTW, what's the normal procedure after rebasing your topic branch, and
pulling into (local) master [and, according to Jim's suggestions on
gnulib mailing list, finally adding your commit info to the ChangeLog, and
git-add ChangeLog
git commit --amend -e
]?
On CVS, instead of 'cvs commit' you'd do 'clcommit'
On GIT, instead of 'git-push' you do...?
--
Chuck
