On Wed, 30 Apr 2008 17:03:19 +0000 (UTC), "Eric Blake" <[EMAIL PROTECTED]> said: > Cygwin 1.7.0 will change the size of MAX_PATH in its headers, but the old > cygwin_conv_to_* API silently suffers from buffer overrun if more than > 256 > bytes occur in the conversion. As a result, cygwin developers wisely > deprecated the old API when adding the new cygwin_path_conv, and > compilation > now issues a warning (which in turn cripples -Werror builds):
Oh, yeah. Eric, could you take a quick look at the cwrapper source code. I think it uses MAX_PATH somewhere...but it doesn't include config.h IIRC, so it can't use HAVE_DECL_CYGWIN_CONV_PATH to determine the correct func. OTOH, the shell function func_emit_cwrapperexe_src() could check $host and uname [Ugh!], and explicitly emit the correct code for 1.7.0. Or maybe the cwrapper itself could do a runtime check. Also, I think the cwrapper uses static buffers of size MAX_PATH, too. Suggestions? -- Chuck
