[PATCH] allow unquoted "test $?"

[Paolo Bonzini]

With git libtool, sh.test is failing.  Either the offending line should 
be fixed, or the attached patch to sh.test should be applied to allow 
not quoting $?.

Thanks!
Paolo

2008-07-31  Paolo Bonzini  <[EMAIL PROTECTED]>

        * tests/sh.test: Allow unquoted "test $?"

diff --git a/tests/sh.test b/tests/sh.test
index 6d2fa20..ac13772 100755
--- a/tests/sh.test
+++ b/tests/sh.test
@@ -55,7 +55,8 @@ if $EGREP -n -e 'test[        ]+(![   ])?(-.[ 
]+)?X' $scrip
 fi

 # Check for using test $... instead of test "$...
-if $EGREP -n -e 'test[         ]+(![   ])?(-.[         ]+)?X?\$' 
$scripts; then
+# Make an exception for $? though
+if $EGREP -n -e 'test[         ]+(![   ])?(-.[         ]+)?X?\$[^?]' 
$scripts; then
   echo "use \`test \"\$...\"' instead of \`test \$'"
   status=$EXIT_FAILURE
 fi