Ralf Wildenhues wrote:
> * Akim Demaille wrote on Wed, Jan 28, 2009 at 04:43:56PM CET:
>> - nuke warnings in the wrappers
>>
>>   The patch at the end of
>>
>>   http://lists.gnu.org/archive/html/libtool/2008-12/msg00069.html
> 
> For this one I'd prefer if Charles and/or Peter took care of it, they
> have a bunch of changes in this area and some discussion going on.
> Actually, I'd prefer to just be able to say "go!" once y'all have agreed
> on a common set of changes.  :-)

My set of changes were already pushed (0aef3579..6631e515)
2009-01-24  Charles Wilson  <...>

        [cygwin|mingw] cwrapper cleanups.
        * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src)
        [file scope]: re-organized includes and portability
        macros. Avoid oldnames on MINGW32 and MSVC for
        setmode/stat/chmod/getcwd/putenv. Declare _putenv on
        MINGW32 when -ansi. Use namespaced macro LT_DEBUGWRAPPER.

This patch ALSO takes care of all but the _CRT_SECURE_NO_DEPRECATE part
of Akim's.

See earlier reply in this thread for why we don't need to worry about
any other magic MSVC macros. So, I think the only remaining
cleanup-warnings patch for the cwrapper is this:

diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index 1c745f4..308a89a 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -3110,6 +3110,9 @@ func_emit_cwrapperexe_src ()
 */
 EOF
            cat <<"EOF"
+#ifdef _MSC_VER
+# define _CRT_SECURE_NO_DEPRECATE 1
+#endif
 #include <stdio.h>
 #include <stdlib.h>
 #ifdef _MSC_VER

OK to push?

--
Chuck




Reply via email to