* Ralf Wildenhues wrote on Sat, May 23, 2009 at 11:00:52PM CEST: > > Hmm, that's interesting; it means that my previous hypothesis was not > correct. But also, it shows another interesting detail: you are running > as root. I don't try the test suite as root very often (but I guess I > should do it more often), and we should recommend users to not compile > as root in general.
Still, I could reproduce the failure of this and one other test with my proposed setup, so I'm applying this to avoid it, and adding you to THANKS. Cheers, Ralf testsuite: cope when some installed libltdl.la has been removed. * tests/old-m4-iface.at (AC_WITH_LTDL): Pass --with-included-ltdl to configure, to ensure we do not accidentally link against a previously installed libltdl.so where the corresponding .la file has been removed, thus we do not add a run path, and the runtime linker then fails to find libltdl.so.7. * tests/configure-iface.at (--with-ltdl-include/lib): Remove -L flags from LDFLAGS to avoid picking up an installed libltdl outside of the default locations. * THANKS: Update. Prompted by report from Patrice Fromy. diff --git a/tests/configure-iface.at b/tests/configure-iface.at index 77e2ebc..59738e0 100644 --- a/tests/configure-iface.at +++ b/tests/configure-iface.at @@ -204,6 +204,18 @@ main_LDADD = $(LIBLTDL) main_DEPENDENCIES = $(LTDLDEPS) libmodule.la ]]) +## Try to avoid linking against a previously installed libltdl found +## with an explicit -L/path. +save_LDFLAGS=$LDFLAGS +LDFLAGS= +for l in $save_LDFLAGS +do + case $l in + -L*) ;; + *) LDFLAGS="$LDFLAGS $l" ;; + esac +done + # We don't use 'libtoolize --ltdl', so that we get an error if the test # tries to build and link against its own ltdl sources: LT_AT_BOOTSTRAP([], [-I _inst/aclocal], [], [--add-missing], [], diff --git a/tests/old-m4-iface.at b/tests/old-m4-iface.at index 1e374d4..64f7e60 100644 --- a/tests/old-m4-iface.at +++ b/tests/old-m4-iface.at @@ -1,6 +1,6 @@ # old-m4-iface.at -- exercise old m4 interface to libtool -*- Autotest -*- # -# Copyright (C) 2005, 2008 Free Software Foundation, Inc. +# Copyright (C) 2005, 2008, 2009 Free Software Foundation, Inc. # Written by Gary V. Vaughan, 2005 # # This file is part of GNU Libtool. @@ -155,8 +155,10 @@ ltdld...@exeext@: ma...@objext@ module.la libltdl/libltdlc.la $(LTCOMPILE) -c -o $@ $< ]]) +# Be sure to use the in-tree libltdl, somebody might have removed +# an installed libltdl.la file. LT_AT_BOOTSTRAP([--ltdl --install], [-I libltdl/m4], [ignore], [ignore], - [--force]) + [--force], [--with-included-ltdl]) LT_AT_EXEC_CHECK([./ltdldemo], 0, [ignore])