On 6/22/2010 7:54 AM, Gary V. Vaughan wrote: > But compile_tag is never set, so the patch is a NOP! > > If that happens with a later patch in your series, please roll all > the compile_tag machinery into a single commit.
But what if that later patch, in order to work correctly, also requires additional prep work? You're possibly opening up a spiderweb of inter-dependencies between patches. I could easily see a series of "nop" patches, each of which is small and easily reviewed in isolation, but all of which are necessary for a single, final "do it" patch. You might be asking, in effect, for "do it" + "all the nops" to be rolled together and presented at once -- in a large, complex, difficult to review patch. Peter has already split his mega patch into small, easily digestible chunks with minimal inter-dependencies. Let's not second guess his decomposition... -- Chuck
