* Charles Wilson wrote on Sun, Jul 04, 2010 at 06:15:06AM CEST: > On 6/26/2010 2:51 PM, Ralf Wildenhues wrote: > > OK. Here's my take on this: if you fix all nits I noted inline below, > > post the updated and tested patch (you decide what testing is needed), > > then you are OK to commit after 72 hours of waiting. FWIW, I'm likely > > not available most of next week; if we find issues later, then I guess > > they'll just have to be fixed afterwards. > > As discussed previously, this version fixes (almost) all of the noted > issues. I didn't change the eval stuff, deferring instead to Ralf's > promised patch to take care of all of that at once.
Thanks for the re-do. > 112: override pic_flag at configure time FAILED (pic_flag.at:48) I will fix this failure. The test has a few issues, also on other systems. > 112 appears to be a new test, and is ELF specific (-fpic/-fPIC has no > meaning on cygwin). It probably should be skipped. > > > So...this is what I intend to push, barring objections. No objections from me, please wait however long I asked you to wait (basically long enough so others have had a chance to chime in). Thanks, Ralf
