On 8/12/2010 12:12 AM, Paolo Bonzini wrote: > * libltdl/config/ltmain.m4sh (func_mode_finish): Split arguments for > directories and *.la files. Add .la files for all directories. > --- > libltdl/config/ltmain.m4sh | 117 > ++++++++++++++++++++++++++------------------ > 1 files changed, 70 insertions(+), 47 deletions(-) > + if test -d "$opt"; then > + func_append libdirs " $opt" > + for file in "$opt"/*.la; do > + test -f "$file" || continue > + if func_lalib_unsafe_p "$file"; then > + func_append libs " $file" > + else > + func_warning "\`$file' is not a valid libtool archive" > + fi > + done
I don't think --mode=finish should modify *all* .la files found in directories passed to it. I think it should register directories with ld.so (as it currently does) but only fixup .la files passed explicitly on the command line. To do otherwise is O(N^2) behavior: every time you install a new libtool library, you "fix" ALL .la files in $prefix/lib (or attempt to) -- even if most of them don't need it, or were already fixed when THEY were installed. -- Chuck
