On 08/29/2010 08:59 AM, Ralf Wildenhues wrote:
-AS_BOX([Configuring AC_PACKAGE_TARNAME${TIMESTAMP:+" (Build:$TIMESTAMP)"} 
AC_PACKAGE_VERSION])
+timestamp_string=
+if test -n "$TIMESTAMP"; then
+  timestamp_string=" (Build:$TIMESTAMP)"
+fi

Why not:

timestamp_string="${TIMESTAMP:+ (Build:$TIMESTAMP)}"

instead of the if/fi?

+AS_BOX([Configuring AC_PACKAGE_TARNAME$timestamp_string AC_PACKAGE_VERSION])

Or, since we know the workaround is to remove the "" inside here-docs, why not:

AS_BOX([Configuring AC_PACKAGE_TARNAME${TIMESTAMP:+ (Build:$TIMESTAMP)} AC_PACKAGE_VERSION])

--
Eric Blake   ebl...@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Reply via email to