Hi Gary, this isn't a full review, I'm just adding a couple of hints that come to mind at first glance.
* Gary V. Vaughan wrote on Thu, Sep 23, 2010 at 05:21:23PM CEST: > This is another silly patch that ends up being mostly edited away > by the next couple of patches in the series... but I think it's > useful to split it out so that you can see what I'm thinking at > each stage. It was also a good exercise because after splitting, > I realised that the original 3/4 didn't apply this concept in all > the places it could have. > > Okay to push? Consistent naming seems like a good idea, however I'll note that while 8.3 file systems with cutoff policy allow to distinguish between 'libtoolize' and 'libtoolize.tmp', they don't do so for 'libtoolize' and 'libtoolizeT'. I normally wouldn't say we still need to really care about this much any more, but we've had some DJGPP fixes in Autoconf and Automake a few months ago due to bug reports. Oh well, dunno if that's relevant. > * Makefile.am (libltdl/m4/ltversion.m4): Rename temporary file > to `ltversion.m4T'. > (libltdl/config/ltmain.sh): Rename temporary file to `ltmain.shT'. > (libtoolize): Rename temporary file to `libtoolizeT'. > (tests/defs): Rename temporary file to `defsT' > (tests/testsuite): Rename temporary file to `testsuiteT'. > (CLEANFILES): Adjust and add `tests/defsT' and `tests/testsuiteT'. Cheers, Ralf
