Hi Peter, * Peter Rosin wrote on Mon, Oct 04, 2010 at 01:25:42PM CEST: > Den 2010-10-02 08:40 skrev Ralf Wildenhues: > > Skip if $NM != $DUMPBIN? But then you'd need to ensure DUMPBIN is set. > > It's a pest that you can have: > > DUMPBIN="link -dump" > NM="dumpbin -symbols" > > or > > DUMPBIN=dumpbin > NM="link -dump -symbols" > > I.e. link -dump is a synonym for dumpbin. > > > How for a slight improvement at least something that's bound to remain > > even if the symbol pipe is rewritten in sed or another language, e.g., > > looking whether ' UNDEF ' or 'Section length' is present? > > I redid it in the same manner the configure test is doing it instead.
Definitely better, also than my suggestion above; thanks. > > Please consider moving testsuite additions which are clearly system- > > specific to other tests which are clearly system-specific, and grouping > > those testing the same systems, or family of systems (such as w32). > > And then using one AT_BANNER for a set of test groups. > > I moved it before deplibs-mingw.at and changed the banner to "Windows > tests.", quietly fixing the cosmetic bug that deplibs-mingw.at isn't a > darwin test to begin with. Ah, good. > > OK with nits below. > > One more iteration since I'm not sure if redoing the configure test > is ok. Go! Thanks, Ralf > Subject: [PATCH] msvc: handle symbols from different files independently. > > * libltdl/m4/libtool.m4 (_LT_CMD_GLOBAL_SYMBOLS) > <dumpbin, lt_cv_sys_global_symbol_pipe>: Make all sections > viable for symbol extraction again when the symbols from a new > file starts. Fixes tests/tagdemo-make.test for MSVC 10. > * tests/dumpbin-symbols.at: New test, making sure we don't > regress. > * Makefile.am (TESTSUITE_AT): Update.