Hello Ollie,
* Ollie Wild wrote on Fri, Oct 22, 2010 at 06:32:08PM CEST:
> 2010-10-21 Ollie Wild <a...@google.com>
>
> Modify --with-pic to support per-package configurations.
> * libltdl/m4/libtool.m4: Modify --with-pic to accept a list of
> package names. Modelled off --enable-shared.
This patch looks ok but it uses $pkg and $p which are not in Libtool's
name space, and it lacks updates to NEWS, libtool.texi, and the test
suite. Oh yes, the --enable-shared code has similar problems, but a
patch shouldn't be held hostage for drive-by bugs. ;-)
Seriously though, if you need help with any of the remaining issues
please ping us.
Thanks,
Ralf
> --- a/libltdl/m4/ltoptions.m4
> +++ b/libltdl/m4/ltoptions.m4
> @@ -326,9 +326,24 @@ dnl AC_DEFUN([AM_DISABLE_FAST_INSTALL], [])
> # MODE is either `yes' or `no'. If omitted, it defaults to `both'.
> m4_define([_LT_WITH_PIC],
> [AC_ARG_WITH([pic],
> - [AS_HELP_STRING([--with-pic],
> + [AS_HELP_STRING([--with-pic@<:@=PKGS@:>@],
> [try to use only PIC/non-PIC objects @<:@default=use both@:>@])],
> - [pic_mode="$withval"],
> + [p=${PACKAGE-default}
> + case $withval in
> + yes|no) pic_mode=$withval ;;
> + *)
> + pic_mode=default
> + # Look at the argument we got. We use all the common list separators.
> + lt_save_ifs="$IFS"; IFS="${IFS}$PATH_SEPARATOR,"
> + for pkg in $withval; do
> + IFS="$lt_save_ifs"
> + if test "X$pkg" = "X$p"; then
> + pic_mode=yes
> + fi
> + done
> + IFS="$lt_save_ifs"
> + ;;
> + esac],
> [pic_mode=default])
>
> test -z "$pic_mode" && pic_mode=m4_default([$1], [default])
