Hello Christophe, * Christophe Jarry wrote on Sun, Sep 04, 2011 at 12:55:37PM CEST: > --- libtool.orig/libltdl/config/ltmain.m4sh 2011-08-31 21:50:53.000000000 > +0200 > +++ libtool.new/libltdl/config/ltmain.m4sh 2011-09-04 12:27:53.000000000 > +0200
Please learn to use git for sending patches; thanks! > @@ -6605,7 +6605,7 @@ > none) ;; > > darwin) > - # Like Linux, but with the current version available in > + # Like GNU/Linux, but with the current version available in This should be "Like linux", because it speaks about version_type names. > # verstring for coding it into the library header > func_arith $current - $age > major=.$func_arith_result > --- libtool.orig/libltdl/m4/libtool.m4 2011-08-31 21:50:53.000000000 > +0200 > +++ libtool.new/libltdl/m4/libtool.m4 2011-09-04 12:27:36.000000000 +0200 > @@ -2633,12 +2633,12 @@ > hardcode_into_libs=yes > ;; > > -# No shared lib support for Linux oldld, aout, or coff. > +# No shared lib support for GNU/Linux oldld, aout, or coff. Ugh. What is oldld? Is it Linux or GNU specific (or both)? Because the urge to call something GNU/Linux is definitely only valid for things that are, in fact, not just one of the two. > linux*oldld* | linux*aout* | linux*coff*) > dynamic_linker=no > ;; > > -# This must be Linux ELF. > +# This must be GNU/Linux ELF. The comment does not match the code below it, see the following line. Not your fault, and generally I don't want to take patches hostage on unrelated bugs, but *please* make this # This must be GNU userland with ELF and > linux* | k*bsd*-gnu | kopensolaris*-gnu) > version_type=linux > need_lib_prefix=no > @@ -3284,7 +3284,7 @@ > lt_cv_deplibs_check_method=pass_all > ;; > > -# This must be Linux ELF. > +# This must be GNU/Linux ELF. Ditto. > linux* | k*bsd*-gnu | kopensolaris*-gnu) > lt_cv_deplibs_check_method=pass_all > ;; > @@ -4066,7 +4066,7 @@ > cxx*) > # Compaq C++ > # Make sure the PIC flag is empty. It appears that all Alpha > - # Linux and Compaq Tru64 Unix objects are PIC. > + # GNU/Linux and Compaq Tru64 Unix objects are PIC. An object compiled with Compaq C++ bears no connection a priori with GNU. I think the statement before is wrong on more grounds, but I'm too lazy to dig history now; please just leave it as it is. Thanks. > _LT_TAGVAR(lt_prog_compiler_pic, $1)= > _LT_TAGVAR(lt_prog_compiler_static, $1)='-non_shared' > ;; > @@ -4121,7 +4121,7 @@ > # Digital/Compaq C++ > _LT_TAGVAR(lt_prog_compiler_wl, $1)='-Wl,' > # Make sure the PIC flag is empty. It appears that all Alpha > - # Linux and Compaq Tru64 Unix objects are PIC. > + # GNU/Linux and Compaq Tru64 Unix objects are PIC. Ditto. > _LT_TAGVAR(lt_prog_compiler_pic, $1)= > _LT_TAGVAR(lt_prog_compiler_static, $1)='-non_shared' > ;; Thanks, Ralf
