Hi Gary. On Friday 25 November 2011, Gary V wrote: > The best reason I can find for keeping the various demo directories > around (despite the fact we already make use of the much better test > harness of Autotest for all our new test cases) from the last time > I wanted to migrate everything out of the legacy testsuite, was that > it exercises the distribution manager's autotools combination on the > testers machine, where the Autotests always use the users autotools. > That's no argument as far as I can see: we want tests to fail as > early as possible on a users machine to help him know things are not > going to work properly if he keeps going - and having the legacy > suite pass is only encouraging users to fight with broken installs. > > This series of patches migrates all 9 of the demo directory test > groups into Autotest, and allows us to remove most of the legacy > testsuite cruft at the end. > Just my 2 cents: I'd like to see the test scripts converted one at the time, rather than one group at the time (and assuming that this is feasible), as I found your huge patches basically un-reviewable in their present state.
> There's still a few legacy tests > left at the end, which I'll tackle later, but at least maintenance > is a whole lot easier now that we don't need to wait for 9 additional > directories to autoreconf every time we run bootstrap, or distcheck, > or roll up a distribution tarball to test on the local network. > > This is all in keeping with the theme of most of the patches I've > posted this year, to make libtool easier and more fun to maintain > and contribute to, in the hope of getting more people involved. > > As usual, subject to feedback, I'll push this whole series in > 72 hours or so. Make distcheck passes for me on my Mac 10.7 and > my Arch Linux x86_64 machines, but it would be great if folks with > access to other machines could give it a spin to see whether I > broke any of the tests during migration... if you'd like a pre- > rolled distro with my pending patches applied to do that, then > please do ask. > If you want to send me such a tarball, I might run the testsuite on Solaris 10, Cygwin 1.5.25, NetBSD 5.1 and OpenBSD 4.6 at least. But then you should allow for more than three days for sending feedback -- at least a week. Regards, Stefano
