On 12/08/2011 03:21 AM, Gary V. Vaughan wrote: > The recently pushed series of patches included the controversial > introduction of an additional 3 forks per invocation, which might > add a minute or two of wall-clock time to giant builds on windows. > By assuming that windows will run shell scripts on some shell with > all the modern optional features that libtool wants, this patch > eliminates even those 3 new forks. > > Okay to push?
I'm a bit reluctant to do this via a host check;
>
> +# Forks are unreasonably slow under Windows, so we assume that, for at
> +# least cygwin and mingw, /bin/sh is bash, and save at least 3 forks per
> +# invocation:
> +case $host in
> + *cygwin* | *mingw*)
Instead of doing it this way, I'd almost rather see:
if test "${BASH_VERSION+set}" = set; then
although if cygwin ever follows debian's lead of using dash for faster
/bin/sh, I'm not sure if there is a reliable forkless way to detect dash.
--
Eric Blake ebl...@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
