On 2013-11-20 00:32, Gary V. Vaughan wrote: > Hi Ozkan, Petor, > > On Nov 19, 2013, at 11:57 PM, Peter Rosin <p...@lysator.liu.se> wrote: > >> On 2013-11-19 10:08, Ozkan Sezer wrote: >>>> Starting with fec7d87 ("funclib.sh: simplify version comparison >>>> functions") I am getting the following error from bootstrap: >>>> >>>> bootstrap: error: 'makeinfo' version == 4.13 is too old >>>> bootstrap: 'makeinfo' version >= 4.8 is required >>>> >>>> 9fd7b88 is fine. >>>> >>>> This is with Fedora 16, with grep-2.9-3.fc16.x86_64, >>>> sed-4.2.1-9.fc16.x86_64, and bash-4.2.37-1.fc16.x86_64 >>>> >>> >>> Will this be fixed anytime soon? >> >> Yes, please. > > Ouch, sorry about that. > >> I came up with this patch, but I don't know how portable it is, so I would >> like someone knowledgeable to comment on it before pushing it... > > I don't have access to any Windows environments, but your patch works > correctly for me on various flavours of Mac OS, GNU/Linux, Solaris, HPUX, > and AIX -- I no longer have access to Tru64 Unix, SCO Unix or IRIX. > > Thanks for the quick fix. Assuming it works on cygwin, mingw and other > windows variants we support, please go ahead and push.
Works on Cygwin, so pushed. During patch development I tested various multi-dotted version numbers with various difficulties of the 4.82.620 vs 4.82.2000, 2.82 vs 10.7 and 4.10 vs 4.100 kind, as well as some simple ones of the 5 vs 8 and 4.3 vs 4.8 variety. *checks some more* Hmmm, just checked 1.4.4a vs 1.4-p3a, and the new sort thinks 1.4-p3a is lesser, which is good I suppose. But the function comment is no longer accurate... I don't know what to write instead in that comment, but with the new sort 1.4-p12a < 1.4-p3a, which looks about as bad as 1.4.4a < 1.4-p3a. Maybe like this: diff --git a/bootstrap b/bootstrap index 852efd5..ca2bb11 100755 --- a/bootstrap +++ b/bootstrap @@ -1312,9 +1312,9 # func_sort_ver VER1 VER2 # ----------------------- # 'sort -V' is not generally available. # Note this deviates from the version comparison in automake -# in that it treats 1.5 < 1.5.0, and treats 1.4.4a < 1.4-p3a +# in that it treats 1.5 < 1.5.0, and treats 1.4-p12a < 1.4-p3a # but this should suffice as we won't be specifying old # version formats or redundant trailing .0 in bootstrap.conf. # If we did want full compatibility then we should probably # use m4_version_compare from autoconf. But I'm not sure if m4_version_compare handles p12a vs p3a, so I'll leave this for Gary to clean up. Cheers, Peter