Hi /haubi/ :), On Dec 5, 2014, at 8:37 AM, Michael Haubenwallner <michael.haubenwall...@ssi-schaefer.com> wrote > On 12/03/2014 11:09 PM, Gary V. Vaughan wrote: >> >> I'm sorry I forgot to thank you for this patch, which I applied in >> time for the recent 2.4.4 release. >> >> On Nov 24, 2014, at 1:09 PM, Michael Haubenwallner >> <michael.haubenwall...@ssi-schaefer.com> wrote: >>> >>> Support filename-based shared library versioning on AIX with the lib.so >>> library filename extension, which is used with runtime linking only. >>> Runtime linking is enabled by the -brtl linker flag for executables and >>> the -G linker flag for Shared Objects. The behaviour is similar to >>> Linux/SVR4 DT_SONAME, hence the name "aix-soname=svr4". >> >> Much appreciated! I did make some slight edits after applying, so >> please check that it still works for you. > > Yes, testsuite results still works as expected. > > One note for the case-separator in tests/versioning.at to remember: > LDFLAGS may contain both ':' and ',' eventually. OTOH, to break here > LDFLAGS value would need to be invalid anyway (sth. like "-Wl,,").
Good point, I hadn't considered that when I changed your patch to match the Libtool style precedent. However, I think it would take an exceptionally pathological case to actually fall into the wrong branch of the case statement, so I'm inclinded not to worry about it just yet. > Thank you so much! No problem! Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)