Summary: remove hard coded paths to /usr/bin/file
                 Project: GNU Libtool
            Submitted by: growpotkin
            Submitted on: Sat 02 Oct 2021 12:19:57 AM UTC
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any



Hard coded paths which invoke file(cmd) fail on certain Linux distributions,
in my case NixOS. I saw a commit from 1999 by Thomas Tanner <tan...@ffi.org> (
) which used to call `AC_CHECK_TOOL(FILE` to handle this, I lost track of
exactly when it was removed, but I assume it was dropped because other macros
use `FILE` when performing compilation/linking checks.

This essentially restores Thomas Tanner <tan...@ffi.org> commit, but instead
of using the name `FILE` I instead use `FILECMD`. I tried to follow patterns
in use by other tools, but feel free to recommend any changes.

This passes everything in `make check` on my NixOS machine, except for
`destdir.at`, `old-ltdl-iface.at`, `cmdline_wrap.at` which appear to be
unrelated to my patch ( they fail on an unmodified build in my environment as
well ). See attached testsuite.log.

This patch is against the "public" master branch, I will rewrite it against
the private one for a merge.


File Attachments:

Date: Sat 02 Oct 2021 12:19:57 AM UTC  Name: filecmd.patch  Size: 3KiB   By:

Date: Sat 02 Oct 2021 12:19:57 AM UTC  Name: testsuite.log  Size: 163KiB   By:



Reply to this item at:


  Message sent via Savannah

Reply via email to