On 07 Jul 2011 15:45, Vadim Zeitlin wrote: > Charles Wilson <libtool <at> cwilson.fastmail.fm> writes: > > On 6/23/2011 5:34 AM, Vadim Zeitlin wrote: > > > Re-declaring _putenv() without _CRTIMP in strict ANSI mode when using > > > MinGW resulted in a warning because of a conflict with the previous > > > declaration that did use _CRTIMP. > > > > > > Simply add _CRTIMP to our declaration to avoid it. > > > > > -int _putenv (const char *); > > > +_CRTIMP int _putenv (const char *); > > > > Probably should also add __cdecl (for correctness, not warning > > suppression) in case the user has done a -mrtd. > > > > _CRTIMP int __cdecl _putenv (const char*); > > Sorry for the delay, I left aside my struggles with libtool for some time, > but am getting back to it now as I'd really like to not have to return to > this again later. > > It's not totally clear to me if I should make this trivial change myself > or whether this would be done by whoever applies the patch? FWIW I clearly > agree that __cdecl should be there, I just didn't think about -mrtd case.
i've done it this time for you due to the vintage, but for future reference, you should always make the updates and post v2/etc... in response to your original patch. -mike
signature.asc
Description: PGP signature