On 23/10/2025 16:16, KO Myung-Hun wrote:
Ping?

KO Myung-Hun wrote:
old_archive_from_new_cmds is not used at all. In addition, if this is
defined static libs are not generated.

This is a regression of commit e60044.

* m4/libtool.m4: Do not define old_archive_from_new_cmds on OS/2.
---
  m4/libtool.m4 | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 18c5fbcd..ea2c1808 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -5313,7 +5313,7 @@ _LT_EOF
        cat $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~
        $CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs 
$compiler_flags $output_objdir/$libname.def~
        emximp -o $lib $output_objdir/$libname.def'
-      _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
$output_objdir/${libname}_dll.a $output_objdir/$libname.def'
+      #_LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
$output_objdir/${libname}_dll.a $output_objdir/$libname.def'
        _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
        _LT_TAGVAR(file_list_spec, $1)='@'
        ;;
@@ -6029,7 +6029,7 @@ _LT_EOF
        cat $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~
        $CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs 
$compiler_flags $output_objdir/$libname.def~
        emximp -o $lib $output_objdir/$libname.def'
-      _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
$output_objdir/${libname}_dll.a $output_objdir/$libname.def'
+      #_LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
$output_objdir/${libname}_dll.a $output_objdir/$libname.def'
        _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
        _LT_TAGVAR(file_list_spec, $1)='@'
        ;;
@@ -6902,7 +6902,7 @@ if test yes != "$_lt_caught_CXX_error"; then
          cat $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~
          $CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs 
$compiler_flags $output_objdir/$libname.def~
          emximp -o $lib $output_objdir/$libname.def'
-       _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
$output_objdir/${libname}_dll.a $output_objdir/$libname.def'
+       #_LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o 
$output_objdir/${libname}_dll.a $output_objdir/$libname.def'
        _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
        _LT_TAGVAR(file_list_spec, $1)='@'
        ;;

Thank you for your patch! Sorry for not replying sooner, it was not
delivered to my inbox. I think the lines should be removed instead of
commented out if they are not needed. Can I apply your patch header with
the lines removed?

--
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354


Attachment: OpenPGP_0x6570EA01146F7354.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to