On Thu, Sep 07, 2000 at 07:53:58PM +0200, Lars J. Aas wrote:
> On Thu, Sep 07, 2000 at 01:41:58PM -0400, Pavel Roskin wrote:
> : Index: ChangeLog
> : --- ChangeLog Thu Sep 7 08:22:46 2000
> : +++ ChangeLog Thu Sep 7 13:36:19 2000
> : @@ -0,0 +1,5 @@
> : +2000-09-07 Pavel Roskin <[EMAIL PROTECTED]>
> : +
> : + * libtool.m4 (_LT_AC_LTCONFIG_HACK): fixed incorrect use of
> : + changequote
> : +
> : Index: libtool.m4
> : --- libtool.m4 Thu Sep 7 13:30:38 2000
> : +++ libtool.m4 Thu Sep 7 13:30:57 2000
> : @@ -597,16 +597,16 @@
> : ## END FIXME
> :
> : # Check for any special shared library compilation flags.
> : -changequote(,)dnl
> : if test -n "$ac_cv_prog_cc_shlib"; then
> : AC_MSG_WARN([\`$CC' requires \`$ac_cv_prog_cc_shlib' to build shared libraries])
> : + changequote(,)dnl
> : if echo "$old_CC $old_CFLAGS " | egrep -e "[ ]$ac_cv_prog_cc_shlib[ ]"
>>/dev/null; then :
> : + changequote([,])dnl
>
> Why not remove the changequote macros completely and use:
> if echo "$old_CC $old_CFLAGS " | egrep -e "[[ ]]$ac_cv_prog_cc_shlib[[
> ]]" >/dev/null; then :
You are entirely correct.
The whole of libtool.m4 and ltdl.m4 will be audited for misuse of
changequote before 1.4 is released.
Cheers,
Gary.
--
___ _ ___ __ _ mailto: [EMAIL PROTECTED]
/ __|__ _ _ ___ _| | / / | / /_ _ _ _ __ _| |_ __ _ ___ [EMAIL PROTECTED]
| (_ / _` | '_|// / |/ /| |/ / _` | || / _` | ' \/ _` | _ \
\___\__,_|_|\_, /|___(_)___/\__,_|\_,_\__, |_||_\__,_|//_/
home page: /___/ /___/ gpg public key:
http://www.oranda.demon.co.uk http://www.oranda.demon.co.uk/key.asc
