Elizabeth Barham wrote:
> 
> Earnie Boyd <[EMAIL PROTECTED]> writes:
> 
> > Ok, submit a proper patch against the CVS source to [EMAIL PROTECTED] for
> > proper credit for the fix.
> 
> Okay, I am satisfied with this and submit this patch for peer review.
> 

Please, use cvs diff -u3p.

> SYNOPSIS:
> 
> Adds a linker flag check for "-shared" before those that are all ready
> defined when building a win32 dll (using the AC_LIBTOOL_WIN32_DLL in
> configure.ac) for a mingw* host.
> 

You need a proper ChangeLog entry.

> Index: libtool.m4
> ===================================================================
> RCS file: /cvsroot/libtool/libtool/libtool.m4,v
> retrieving revision 1.264
> diff -r1.264 libtool.m4
> 510c510
> <     # require "-mdll"
> ---
> >     # require "-mdll" (and still newer ones would rather have "-shared")
> 512c512
> <     CFLAGS="$CFLAGS -mdll"
> ---
> >     CFLAGS="$CFLAGS -shared"
> 514c514,517
> <       [AC_TRY_LINK([], [], 
>[lt_cv_cc_dll_switch=-mdll],[lt_cv_cc_dll_switch=-dll])])
> ---
> >       [AC_TRY_LINK([], [], [lt_cv_cc_dll_switch=-shared],
> >         [
> >          CFLAGS="$SAVE_CFLAGS -mdll"
> >        AC_TRY_LINK([], [], 
>[lt_cv_cc_dll_switch=-mdll],[lt_cv_cc_dll_switch=-dll])])])
> 

That's all there is?! ;)  Looks, good.

Thanks,
Earnie.


_______________________________________________
Libtool mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/libtool

Reply via email to