> On Jul 2, 2024, at 12:01 PM, Václav Haisman <vhais...@gmail.com> wrote: > > On 28. 06. 24 0:41, Ozkan Sezer wrote: >> [Sorry, I seem to have deleted the mailing list message from my inbox] >> Regarding -no_fixup_chains patch i.e. >> >> http://git.savannah.gnu.org/gitweb/?p=libtool.git;a=commitdiff;h=3d1baeeef90a6b9e16c545babe833f28dca155a7 >> Is '+=' universally supported?? Maybe change to something like the >> following?? > > Is there a reason not to use AS_VAR_APPEND? > (https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Polymorphic-Variables.html) > >> diff --git a/m4/libtool.m4 b/m4/libtool.m4 >> index 381d4cb..31f1be0 100644 >> --- a/m4/libtool.m4 >> +++ b/m4/libtool.m4 >> @@ -1032,3 +1032,3 @@ >> [ save_LDFLAGS=$LDFLAGS >> - LDFLAGS+=" -Wl,-no_fixup_chains" >> + LDFLAGS="$LDFLAGS -Wl,-no_fixup_chains" >> AC_LINK_IFELSE( >> @@ -1093,3 +1093,3 @@ _LT_EOF >> if test yes = "$lt_cv_support_no_fixup_chains"; then >> - _lt_dar_allow_undefined+=' $wl-no_fixup_chains' >> + _lt_dar_allow_undefined='$_lt_dar_allow_undefined >> $wl-no_fixup_chains' >> fi
AS_VAR_APPEND goes through a lot of setup at Libtool build-time, and eventually ends up calling a shell function as_fn_append at runtime anyway. Since Libtool includes funclib.sh, it would be simpler to use func_append in this case: https://github.com/gnulib-modules/bootstrap/blob/master/build-aux/funclib.sh#L532-L549 Cheers, Gary
