On Fri, Nov 11, 2011 at 01:40:52PM +0100, Lassi Tuura wrote: > Hi Paul, > > > Attached patch almost entirely mechanically copies x86_64/Gtrace.c and > > x86_64/Gstash_frame.c to x86. > > Nice, thanks for doing the port. It looks mostly fine to me, some notes > below. We don't use 32-bit any more, so it kind of fell off my radar, and > I don't really have an environment to even test these. I was mainly > concerned there are too many real-life systems with poor signal stack > annotations in x86 world, or some other simplifying assumptions broke. > These are not an issue with x86_64 - and I don't really have access to > anything but recent distributions where this probably isn't an issue. > > The notes: > > * There are a few instances of 'rbp', 'rsp', 'RBP', 'RSP' in comments in > include/tdep-x86/libunwind_i.h and src/x86/Gtrace.c you might edit. > > * It seems you use LINUX_SC_EIP_OFF etc. I think this code is also used > on FreeBSD, so I am not sure if there will be problems with that. Maybe > Konstantin could confirm that for you? Well, I will fix the breakage if the submitter care only about Linux, either before or after the patch is committed. I prefer to do it after the commit, since then I am sure that I handle the latest version.
pgp80xG1hZG98.pgp
Description: PGP signature
_______________________________________________ Libunwind-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/libunwind-devel
