On Mon, Mar 12, 2012 at 08:26:52PM -0700, Arun Sharma wrote: > I copied your patches + some build fixes for x64 to: > > https://github.com/adsharma/libunwind/commits/coredump2 > > Please verify that everything still works on your end. Some loose ends > to be tied up before I can push to libunwind HEAD: > > * tests/test-coredump-unwind doesn't test anything right now. An > actual test that fails if future commits break things would be great. > This might require a test core dump file for every platform you care > about. I think it is requirement to generate a coredump on machine where the testing is performed.
> > * _UCD_libs.h seems to have a different license. Please let me know if > relicensing is possible. > > * I suspect ia64 is broken by 2.patch > > $ grep -i ia64 src/dwarf/Gfind_unwind_table.c > #if UNW_TARGET_IA64 > > ia64 is not a dwarf platform and shouldn't be using stuff under > src/dwarf. Please send me an incremental diff to move that code back > to the original location. > > People working on other platforms: please verify that this works for > you (or at least doesn't break anything). It does break build. Please look at http://people.freebsd.org/~kib/git/libunwind.git/ branch coredump2, were I made it at least compilable for FreeBSD/i386 and FreeBSD/amd64. The commit 52a8e2119d86a55218b8bf131f46a78fdac861dd is probably wrong, I do not have Linux machine to test. I am not sure how to test the functionality. > > -Arun > > PS: git clone -b coredump2 git://github.com/adsharma/libunwind.git
pgpQ6mNOUo95q.pgp
Description: PGP signature
_______________________________________________ Libunwind-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/libunwind-devel
