On Mon, Aug 13, 2012 at 6:58 AM, Martin Milata <[email protected]> wrote: >> If the second lookup fails with -UNW_ENOMEM, looks like you propagate >> that error up the stack. Why not propagate the best known answer from >> the first lookup? > > The idea is that usually only the closest symbol is useful as it > corresponds to the procedure name. If the closest symbol is too large > and some other one that fits in the buffer is returned, it will most > likely be name of some unrelated procedure. > > Also, such behaviour is consistent with what the original > unw_get_proc_name does - it returns the closest symbol regardless of > whether it's truncated or not. Or am I missing something?
No - this sounds fine. Was trying to make sure that this was intentional :) I've merged this patch set as well. -Arun _______________________________________________ Libunwind-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/libunwind-devel
