[Libunwind-devel] [patch] Fix heap buffer overflow in test-coredump-unwind.c

[Paul Pluzhnikov]

Greetings,

We've tried to run slightly modified test-coredump-unwind.c built with
tcmalloc, and it promptly crashed.

Attached patch fixes the heap buffer overflow bug which caused it.

Thanks,


-- 
Paul Pluzhnikov

diff --git a/tests/test-coredump-unwind.c b/tests/test-coredump-unwind.c
index 22fe9e4..5349823 100644
--- a/tests/test-coredump-unwind.c
+++ b/tests/test-coredump-unwind.c
@@ -137,7 +137,7 @@ static void verror_msg_helper(const char *s,
   if (flags & LOGMODE_STDIO)
     {
       fflush(stdout);
-      used += write(STDERR_FILENO, msg, used + msgeol_len);
+      write(STDERR_FILENO, msg, used + msgeol_len);
     }
   msg[used] = '\0'; /* remove msg_eol (usually "\n") */
   if (flags & LOGMODE_SYSLOG)

_______________________________________________
Libunwind-devel mailing list
Libunwind-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/libunwind-devel