Hi, The commit changes the message in sysfs_get_active_config() to debug level and adds the same message to op_get_configuration() as error.
The sysfs_ function reads the kernel's cached value of the configuration and is called from a few places in the backend. The op_ function is the backend call for libusb_get_configuration(). The purpose of moving the usbi_err() message is probably to still output the error when the public API is called, but maybe it's just as good to delete one of the messages then? It seems a little redundant to have the same message in two places. I would delete the usbi_err() message in the op_ function. Another entry point is libusb_get_active_config_descriptor() which calls either the sysfs_ function or the corresponding usbfs_ function. If sysfs_ then there would be the debug message but no error, since op_get_active_config_descriptor() doesn't have an usbi_err() call (and IMO shouldn't have one). Hm? //Peter ------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ libusbx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libusbx-devel
