Ack for the new version :)

p.s.

Any chance you could send patches inline? That makes it much easier
to comment on them when reply-ing.

Hint, try git send-email.

Regards,

Hans


On 04/20/2012 11:26 AM, Ludovic Rousseau wrote:
> Le 20 avril 2012 11:09, Hans de Goede<[email protected]>  a écrit :
>> Hi,
>>
>> NACK. You cannot change number_of_packets in
>> linux_usbfs.h:struct usbfs_urb from int to unsigned int,
>>
>> linux_usbfs.h is a private copy of
>> /usr/include/linux/usbdevice_fs.h, to allow compiling with
>> older kernel-headers without a whole lot of #ifdef ugliness.
>>
>> IOW this file defines the userspace kernel ABI and you cannot
>> just go and change that!
>>
>> An alternative, and much simpler fix (untested) is probably
>> to just change num_retired from unsigned int to int.
>
> Good suggestion. The patch is much more simpler. Just 1 line to change
> and 3 less warnings.
> Patch attached.
>
> Bye
>
>
>
>
> ------------------------------------------------------------------------------
> For Developers, A Lot Can Happen In A Second.
> Boundary is the first to Know...and Tell You.
> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
> http://p.sf.net/sfu/Boundary-d2dvs2
>
>
>
> _______________________________________________
> libusbx-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/libusbx-devel

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
libusbx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libusbx-devel

Reply via email to