Hi, On 04/21/2012 12:10 AM, Pete Batard wrote: > All the patches previously mentioned have now been pushed. > If I forgot anything, please let me know. You'll see that I merged a few > of the Linux one-liners and also added the BSD get_speed patch from > libusb.git. > > Next, I'd like to pick up the "Linux: Search for > /dev/usbdev<bus>.<device> USB device special files" [1] patch, but > before I do that, I wouldn't mind if the Linux people get a chance to > look at it.
I just reviewed the patch as found in git.libusb.org/libusb.git and it looks good. > The timestamp patch [2] is interesting as well, since we've been wanting > it for a long time. But this deserves proper review and I don't think > any occurred on libusb-devel (though I haven't monitored it that closely > lately). > Also reviewed it, looks good to me too. > For one thing, we may also want to take this opportunity to add a thread > ID along with the timestamp, as it can be quite useful when debugging > multithreaded apps, which we've had to do a few times in the past. > > Also, I wonder if there would be any rationale to make it toggleable? My > guess would be that if people have logging enabled, they won't have much > to gain from disabling timestamp, but maybe someone can point out to > cases where they think it may be helpful? While talking about syncing to Peter's tree, I've noticed that he has added 2 fields to our new libusb_version struct. Luckily we only return and never take a pointer to that struct so we can safely grow it. Thus I suggest that we also add those field to keep ABI compatibility with Peter's version of the get_version API. Regards, Hans ------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
