On 13/07/12 14:06, Pete Batard wrote: >> I've put an alternative fix into the branch which I plan to keep rebased >> on libusbx/master: >> https://github.com/tobygray/libusbx/commit/4b0f2413ae85d197db8721e2fda5a85355d95e1b >> >> The only thing I'm not sure of in this fix is that wince_usb.c doesn't >> seem like it's quite the right place for it. What do you think? > Lately I've been fond of putting generic features that are commonly > found on POSIX, and that MS compilers need to emulate, into a custom > unistd.h. Most of that applied to macros, but I guess we could extend it > provide both a custom unistd.h and unistd.c for the getenv > implementation. Now, if Microsoft ever decides to provide an unistd.h we > may have some issue, so maybe a missing.h/missing.c would work just as > well, and be more explicit. > > Still, it may be a bit of an overkill to create separate a source if > it's just for getenv, and considering that there are probably quite a > few generic calls in windows_usb.c that could be better off in a > separate source, I'm not sure I have much ground asking you to split > that call unless you want to...
Moving it to a missing.c file seems like a sensible plan. This has been done in the following commit: https://github.com/tobygray/libusbx/commit/d4db405e57301f94578f8175af01b4edf2ed4c16 > OK. I can delete the ref in the comment if you want, as it was more of a > means to figure out how to reference commits for other github repos in > comments (<username>/<project>@<commit hash>) than anything else. > > If you want to delete the branch, I'll update the reference to point to > the master commit in libusbx once I apply it. I'll just keep the branch around until it's been applied to libusbx master. > I'll also do my best to make sure we deal with your patch while it's > hot, as it often becomes a lot more time consuming for everybody not to > deal with things as they come along. Thanks, it'll be good to get this sorted quickly. However I'm happy to keep on doing a rebase of my WinCE branch off libusbx master for as long as I need to. > For the record, I have updated the 1.0.13 milestone [1] to mention the > CE integration effort. I have also moved the "add testlibusb sample or > an ISOC sample" task from 1.0.13 to 1.0.14 as a result (IMO, the least > important item we had). Delaying this task shouldn't be much of an issue > as we will of course try to accommodate goals when new items come along, Brilliant that'd be great thanks. Let me know if I can do anything more to help out. Regards, Toby ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
