Hi,
On 08/04/2012 10:59 AM, Hans de Goede wrote:
> Hi,
>
> On 08/03/2012 02:46 PM, Pete Batard wrote:
>> Attached is my final proposal then.
>>
>
> Looks good, ack.
>
Correction, you forgot to add the arm_timerfd_for_next_timeout() call we
agreed would be added to the transfer submission failure path in
libusb_submit_transfer(), iow. This:
r = usbi_backend->submit_transfer(itransfer);
if (r) {
usbi_mutex_lock(&ctx->flying_transfers_lock);
list_del(&itransfer->list);
usbi_mutex_unlock(&ctx->flying_transfers_lock);
}
Should be changed to:
r = usbi_backend->submit_transfer(itransfer);
if (r) {
usbi_mutex_lock(&ctx->flying_transfers_lock);
list_del(&itransfer->list);
arm_timerfd_for_next_timeout(ctx);
usbi_mutex_unlock(&ctx->flying_transfers_lock);
}
Note I've not added error checking to the arm_timerfd_for_next_timeout() call,
since we are already returning an error here, and the submission failure
error code is more important then the timer one.
So I replace my ACK with a conditional-ack with the condition being adding
the above change :)
Regards,
Hans
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
libusbx-devel mailing list
libusbx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libusbx-devel
