On 2012.08.23 11:09, Hans de Goede wrote:
> Well this is the reason why I'm using __u32 here, since our linux_usbfs.h
> is an (almost) 1 on 1 copy of linux/usbdevice_fs.h, so I think unnecessarily
> deviating from the original is not a good idea

Deviating from using platform specific custom nonstandard types to using 
*UNIVERSAL* standard types is always a good idea, especially if your 
code is public.

> but if you insist on changing the __u32 to uint32_t

I do. For the love of God, STOP using custom integer types when the ones 
that have been provided to you for well over 10 years in stdint.h will do!

Your 3 patches have now been pushed (with uint32_t on the first).

Regards,

/Pete


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
libusbx-devel mailing list
libusbx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libusbx-devel

Reply via email to