On Wed, Mar 6, 2013 at 8:04 AM, Xiaofan Chen <xiaof...@gmail.com> wrote: > On Wed, Mar 6, 2013 at 4:59 AM, Pete Batard <p...@akeo.ie> wrote:
>> I have now pushed the patch reversal to mainline, and closed #96 since >> by all account we should be sending 0xC1 as expected, and at least with >> the device I tested against, I have yet to see an issue be it on >> Windows, Linux or OS X. > > The patch looks correct. However, with the benchmark firmware, I do not > have issues without the patch but have issues with the patch. Again, > kind of strange. Tested under Windows 7 x86. Okay, I tested with different driver and libusbk.sys/libusb0.sys are both okay with the latest git. So the problem is only with winusb. The issue may be what you have stated in the original code. // NB: We should use os_fd[i].recipient instead of LIBUSB_RECIPIENT_DEVICE above, as // LIBUSB_RECIPIENT_INTERFACE should be used for the Extended Properties. // However, for Interface requests, the WinUSB DLL forces the low byte of wIndex // to the interface number, regardless of what you set it to, so we have to // fallback to Device and hope the firmware answers both equally. // See http://www.lvr.com/forum/index.php?topic=331 For WinUSB, we really have to use LIBUSB_RECIPIENT_DEVICE instead of LIBUSB_RECIPIENT_INTERFACE for the current codes. And indeed with that change, the latest git will work under Windows. I think the patch is anyway correct and Ticket 96 can be closed. But a note on WinUSB may be necessary here. -- Xiaofan ------------------------------------------------------------------------------ Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
