On May 20, 2013, at 4:43 PM, Pete Batard <p...@akeo.ie> wrote: > On 2013.05.20 17:06, Nathan Hjelm wrote: >> On May 20, 2013, at 09:51 AM, Toby Gray <toby.g...@realvnc.com> wrote: >>> I've attached a handful of patches of changes needed to get WinCE >>> building (I've not tried it on hardware yet). I suspect that people will >>> have strong opinions on the first patch which creates poll_posix.c. > > Actually, even if the new source will be rather small, I think it'll > make our implementation cleaner (especially as we already have a > poll_posix.h anyway, that used to #define usbi_pipe), so with Nathan's > reservations below, I'm +1 on this one. > >>> Hopefully the other patches aren't as controversial. > > They look good to me. > >> If we want to abstract calls to pipe why not 1) make usbi_pipe take an >> option as to whether the pipe should be blocking or non-blocking, > > Seconded. > >> and 2) >> change the one call to pipe to be a call to usbi_pipe instead of using >> #define? > > Maybe I'm missing something there. > > Would we still have a naked call to pipe anywhere on POSIX after this > patch is applied? > If there is one, then I also agree with what Nathan says, but I'm not > sure what section of code we're talking about. As far as I can see, > usbi_io_init() in io.c is already using usbi_pipe().
There are no naked calls to pipe except in the darwin backend so I don't know why the #define was done as it shouldn't be necessary. -Nathan ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
