Hi, On 06/27/2013 06:22 PM, Chris Dickens wrote: > Hi, > > > On Thu, Jun 27, 2013 at 3:31 AM, Hans de Goede <hdego...@redhat.com > <mailto:hdego...@redhat.com>> wrote: > > Hi, > > +/* device will still be marked as attached if hotplug monitor thread > +* hasn't processed remove event yet */ > +if (handle->dev->attached) { > > > This check is racy, you need to take the hotplug lock before making this > check, also linux_device_disconnected expects the hotplug lock to be > taken when it is called, so simply but a check around the entire block. > > > Ok, patch revised. With the current design this race condition is benign, but > better to be safe than sorry if something changes in the future. > > Ok, that makes sense, I can live with having a check in 2 places, please > respin with the suggested > fixes and send with git send-email, or attach, so that your mail client > does not foobar the patch. > > > Patch is attached.
Thanks, looks good. But given that I've already broken stuff, thus delaying 1.0.16rc2 by merging Toby's "Improved logging v2" patch, I think it is best to delay applying this till after we open up development for 1.0.17. Regards, Hans ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
