On Aug 26, 2013, at 04:22 PM, Sean McBride <s...@rogue-research.com> wrote:

On Mon, 26 Aug 2013 20:47:33 +0200, Ludovic Rousseau said:

I use Coverity as _another_ static analysis tool for my free software
projects.

The clang static analyzer also gives one error in current git master:

libusbx/libusb/os/darwin_usb.c:533:34: Access to field 'device' results in a dereference of a null pointer (loaded from variable 'dev')

You need to see the flow analysis to understand how it gets to that conclusion, I've attached zipped HTML that shows it.
 
Hmm, the conclusion is wrong. If ret > -1 the cached_device is always not NULL. I should probably change:

if (ret < 0 || (cached_device && !cached_device->can_enumerate)) {

to:

if (ret < 0 || !cached_device->can_enumerate) {

to reflect this.

-Nathan
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and 
AppDynamics. Performance Central is your source for news, insights, 
analysis and resources for efficient Application Performance Management. 
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
libusbx-devel mailing list
libusbx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libusbx-devel

Reply via email to