Hi, On 09/05/2013 03:14 AM, Xiaofan Chen wrote: > On Thu, Sep 5, 2013 at 3:26 AM, Hans de Goede <hdego...@redhat.com> wrote: >> Hi, >> >> As discussed in much detail here: >> https://bugzilla.redhat.com/show_bug.cgi?id=1003193 >> >> Calling libusb_exit from atexit from libusb-compat-0.1.5 causes >> some apps to break. >> >> The app in question is the scanimage app from sane-backends, which >> uses atexit for cleanup itself. >> >> So what happens is the libusb-compat atexit handler runs first, and >> then the scanimage atexit cleanup code runs, and tries to cleanly >> shutdown the scanner (which may require communicating to it). >> ... >> I consider this behavior with some old apps a way bigger problem then the >> memory / resource leak we had before, therefor I suggest reverting the >> atexit changes to libusb-compat. >> > > I agree. > > On the other hand, maybe we then have to document this limitation > of libusb-compat.
You mean simply document that atexit is used and apps must not make any calls from atexit because there are no ordering guarantees? Or you mean revert the patch and then document the resource leak ? Also what do others think? Pete ? Nathan ? > BTW, do we need to replicate the libusb.org libusb-compat tickets in > libusbx github? Only Ticket 110 and 32 need to be copied as other > tickets have been closed. > http://www.libusb.org/report/10 > > If yes, then I will copy the two tickets and add "Compat" in the > beginning of the description to distinguish them from libusbx tickets. I think we should not count on libusb.org trac being available for ever, so yes cloning open issues seems like a good idea. About adding a "Compat: " header to the description, wouldn't it be better to simply enable issue tracking on: https://github.com/libusbx/libusb-compat-0.1 Here: https://github.com/libusbx/libusb-compat-0.1/settings Instead, and then file issues for it here: https://github.com/libusbx/libusb-compat-0.1/issues ? Regards, Hans > > > ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
