Hi Jonathan,
On Mon, 25 Jan 2010, Bian, Jonathan wrote:
I agree that direct transfer of VA surface to GL texture is preferred
over the TFP approach. Let's try to finalize the API first. Do you have
an updated proposal on this?
Well, I have not changed the API for some time and I am now exclusively
using vaCopySurfaceGLX(). i.e. we can drop the previous associate,
deassociate, begin and end functions. If you can implement that in GMA500
or MRST drivers without TFP this will be really fine as is.
Here is a stripped down version of va_glx.h.
Basically:
- vaGetDisplayGLX()
- vaCreateSurfaceGLX()
- vaCopySurfaceGLX()
- vaDestroySurfaceGLX()
pretty simple.
Some quick notes:
- The GLX context is expected to be live (glXMakeCurrent()) at the time
the VA/GLX functions are called. We could add the GLX context to
vaGetDisplayGLX() but in that case an implementation will have to
glXMakeCurrent() itself and restore the previous context itself.
- The GL texture format is to be detected by the implementation. In my
current implementations, that's only GL_RGBA or GL_BGRA.
- The vaCopySurfaceGLX() function transfers the surface to the texture,
carrying on colorspace conversion at the same time. Are people interested
in NV12 pixels instead? In that case, we would need more elaborated API to
map/unmap those to GL textures. In practise, this is not possible on AMD
HW as the driver can only do transfers from NV12 to RGBA|BGRA anyway.
- The VA/GLX surface type is simply void * for now but it could be a
VASurfaceID if you fully implement the API in GMA500 and MRST drivers. The
reason for a void * was for me to keep track of the data at the libVA
level for the generic implementation through TFP. I would have required
further tweaks with object_heap.c & stuff like that. But void * is fine
too.
Thanks,
Gwenole.
/*
* Copyright (C) 2009 Splitted-Desktop Systems. All Rights Reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the
* "Software"), to deal in the Software without restriction, including
* without limitation the rights to use, copy, modify, merge, publish,
* distribute, sub license, and/or sell copies of the Software, and to
* permit persons to whom the Software is furnished to do so, subject to
* the following conditions:
*
* The above copyright notice and this permission notice (including the
* next paragraph) shall be included in all copies or substantial portions
* of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
* OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT.
* IN NO EVENT SHALL PRECISION INSIGHT AND/OR ITS SUPPLIERS BE LIABLE FOR
* ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
#ifndef VA_GLX_H
#define VA_GLX_H
#ifdef IN_LIBVA
#include "va.h"
#else
#include <va/va.h>
#endif
#include <GL/glx.h>
#ifdef __cplusplus
extern "C" {
#endif
/**
* Return a suitable VADisplay for VA API
*
* @param[in] dpy the X11 display
* @return a VADisplay
*/
VADisplay vaGetDisplayGLX(
Display *dpy
);
/**
* Create a surface used for display to OpenGL
*
* The application shall maintain the live GLX context itself.
* Implementations are free to use glXGetCurrentContext() and
* glXGetCurrentDrawable() functions for internal purposes.
*
* @param[in] dpy the VA display
* @param[in] target the GL target to which the texture needs to be bound
* @param[in] texture the GL texture
* @param[out] gl_surface the VA/GLX surface
* @return VA_STATUS_SUCCESS if successful
*/
VAStatus vaCreateSurfaceGLX(
VADisplay dpy,
GLenum target,
GLuint texture,
void **gl_surface
);
/**
* Destroy a VA/GLX surface
*
* The application shall maintain the live GLX context itself.
* Implementations are free to use glXGetCurrentContext() and
* glXGetCurrentDrawable() functions for internal purposes.
*
* @param[in] dpy the VA display
* @param[in] gl_surface the VA surface
* @return VA_STATUS_SUCCESS if successful
*/
VAStatus vaDestroySurfaceGLX(
VADisplay dpy,
void *gl_surface
);
/**
* Copy a VA surface to a VA/GLX surface
*
* This function will not return until the copy is completed. At this
* point, the underlying GL texture will contain the surface pixels
* in an RGB format defined by the user.
*
* The application shall maintain the live GLX context itself.
* Implementations are free to use glXGetCurrentContext() and
* glXGetCurrentDrawable() functions for internal purposes.
*
* @param[in] dpy the VA display
* @param[in] gl_surface the VA/GLX destination surface
* @param[in] surface the VA source surface
* @param[in] flags the PutSurface flags
* @return VA_STATUS_SUCCESS if successful
*/
VAStatus vaCopySurfaceGLX(
VADisplay dpy,
void *gl_surface,
VASurfaceID surface,
unsigned int flags
);
#ifdef __cplusplus
}
#endif
#endif /* VA_GLX_H */
_______________________________________________
Libva mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libva
