On Tue, Aug 21, 2012 at 12:33 AM, Gwenole Beauchesne <gb.de...@gmail.com> wrote: > Hi, > > 2012/8/17 Daniel Charles <daniel.char...@intel.com>: >> +#ifdef ANDROID_PRE_JB >> #include <surfaceflinger/ISurfaceComposer.h> >> #include <surfaceflinger/Surface.h> >> #include <surfaceflinger/ISurface.h> >> #include <surfaceflinger/SurfaceComposerClient.h> >> +#elif ANDROID_JB >> +#include <gui/ISurfaceComposer.h> >> +#include <gui/Surface.h> >> +#include <gui/ISurface.h> >> +#include <gui/SurfaceComposerClient.h> >> +#endif >> #include <binder/MemoryHeapBase.h> >
An observation here is that only the directory names changed, not the header names. This means the #ifdefs can be dropped and handle the directory inside the Android.mk by setting the LOCAL_C_INCLUDES appropriately. > I would prefer a more generic ANDROID_CHECK_VERSION() macro. e.g. > #if ANDROID_CHECK_VERSION(4,1,0) > ... > #else > ... > #endif > > by probably decomposing PLATFORM_VERSION into major/minor/micro. > > Thanks, > Gwenole. > _______________________________________________ > Libva mailing list > Libva@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libva -- Regards! http://groleo.wordpress.com _______________________________________________ Libva mailing list Libva@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libva