Hi,

I was told to send the attached patch to this list for discussion. It
is about troubles trying to build libva without wayland stuff
installed. The configure of libva-1.6.0 fails:

checking for WAYLAND... no
checking for pkg-config... (cached) /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for WAYLAND_SCANNER... no
configure: error: Package requirements (wayland-scanner) were not met:

No package 'wayland-scanner' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables WAYLAND_SCANNER_CFLAGS
and WAYLAND_SCANNER_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.


The same  for libva-1.6.1 works. It also works for 1.6.0 when
regenerating the configure script using `autoreconf -iv`. The whole
thing is discussed in

        https://bugs.freedesktop.org/show_bug.cgi?id=79478

and I made a patch that moves the wayland scanner code into the main
conditional and assume that this should fix things. But: I now realized
that the simple regeneration of the configure script without any patch
also works. I guess that a system with wayland installed creates
configure scripts that fail without wayland and systems without wayland
create configure scripts that are missing pieces to enable wayland …

I hope future releases of libva can me made to include a configure
script that works for both cases.


Alrighty then,

Thomas
--- libva-1.6.0/configure.ac	2015-07-01 09:52:44.000000000 +0200
+++ libva-1.6.0.fixed/configure.ac	2015-08-18 11:17:17.481068815 +0200
@@ -275,14 +275,15 @@
     if test "$USE_WAYLAND" = "yes"; then
         AC_DEFINE([HAVE_VA_WAYLAND], [1],
                   [Defined to 1 if VA/Wayland API is built])
+        m4_ifdef([WAYLAND_SCANNER_RULES],
+            [WAYLAND_SCANNER_RULES(['$(top_builddir)/va/wayland/protocol'])],
+            [wayland_scanner_rules=""; AC_SUBST(wayland_scanner_rules)])
+    else
+        AC_MSG_ERROR([Wayland selected but not found in system.])
     fi
 fi
 AM_CONDITIONAL(USE_WAYLAND, test "$USE_WAYLAND" = "yes")
 
-m4_ifdef([WAYLAND_SCANNER_RULES],
-    [WAYLAND_SCANNER_RULES(['$(top_builddir)/va/wayland/protocol'])],
-    [wayland_scanner_rules=""; AC_SUBST(wayland_scanner_rules)])
-
 pkgconfigdir=${libdir}/pkgconfig
 AC_SUBST(pkgconfigdir)
 
_______________________________________________
Libva mailing list
Libva@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libva

Reply via email to