On 08/20/2014 10:20 AM, Michal Privoznik wrote: > On 20.08.2014 02:17, Taowei wrote: >> --- >> src/vbox/vbox_common.c | 28 ++++++++++++++++++++++++++++ >> src/vbox/vbox_tmpl.c | 24 ------------------------ >> src/vbox/vbox_uniformed_api.h | 3 +++ >> 3 files changed, 31 insertions(+), 24 deletions(-)
>> + if ((data->pFuncs == NULL) ||
>> + (data->vboxObj == NULL) ||
>> + (data->vboxSession == NULL))
>> + goto cleanup;
>
> While you're at this you can reformat these, s/ +==/ ==/.
> Here and in the rest of the patches.
Or even shorter (dropping redundant (), and using ! instead of
comparison against NULL):
if (!data->pFuncs || !data->vboxObj || !data->vboxSession)
goto cleanup;
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
