Sure - probably not a good idea to send patches at such a late hour anyway :) Attached diff.
Some more details: For those using SDL ("for some crazy reason" as Berrange put it in the original patch), there is a use for the fullscreen option, causing the qemu window to open in full screen, change resolution, etc. This patch accepts an additional attribute in the graphics element: <graphics type='sdl' display=':0.1' xauth='/root/.Xauthority' fullscreen='true'/> If fullscreen is true, "-full-screen" is added to the qemu command line (unlike the display and auth which are added as environment variables) > -----Original Message----- > From: Daniel Veillard [mailto:[EMAIL PROTECTED] > Sent: Wednesday, December 10, 2008 9:49 AM > To: Itamar Heim > Cc: Libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH] add fullscreen support to qemu sdl xml > (via fullscreen='true' attribute for the graphics element) > > On Tue, Dec 09, 2008 at 07:12:05PM -0500, Itamar Heim wrote: > > diff --git a/src/domain_conf.c b/src/domain_conf.c > > Hum, I don't know how you sent the diff, but it got broken when > reaching my mail agent. Please add as an attachment. > Also in general it's a good idea to put some text describing really > what the patch does and what is affected, a one line mail subject > is a bit short. Especially for thing modifying the XML format, > the construct changes ought to be clearly documented. > Adding the regression tests is nice, thanks, but we also need > to augment the .rng schemas to handle the extension if accepted > and the HTML documentation also need the update. We can do it but > providing the complete details helps :-) > > So could you please repost the patch with detail of the syntax > change and as an attachment, > > thanks in advance, > > Daniel > > > + if (vm->def->graphics->data.sdl.fullscreen && > > > > + STREQ(vm->def->graphics->data.sdl.fullscreen, "true")) { > > > > + fullscreen=true; > > > > + } > > > > + > > > -- > Daniel Veillard | libxml Gnome XML XSLT toolkit > http://xmlsoft.org/ > [EMAIL PROTECTED] | Rpmfind RPM search engine http://rpmfind.net/ > http://veillard.com/ | virtualization library http://libvirt.org/
fullscreen.diff
Description: Binary data
-- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list