----- Original Message ----- > From: "Peter Krempa" <[email protected]> > To: "Francesco Romani" <[email protected]>, [email protected] > Sent: Monday, September 15, 2014 2:25:08 PM > Subject: Re: [libvirt] [PATCHv5 0/8] bulk stats: QEMU implementation
[...] > > ChangeLog > > > > v5: address reviewer's comment > > - Eric pointed out a possible flaw in balloon stats if QEMU monitor needs > > to be queried. A proper fix require further discussion and API changes > > (possbily just a new flag); However, since the balloon event is available > > in QEMU >= 1.2, I just dropped the query and relied on the event instead. > > Support for older QEMUs will be reintroduced, if needed, with following > > patches. > > - fix: per-domain monitor check and reporting. (pointed out by Peter) > > - reset last error when fail silently. (pointed out by Peter) > > The changes look good. I've done a few finishing touches and I'm going > to give the series some testing before pushing. The series should be > pushed by today after I finish. > > Thanks for your cooperation in finishing this. My pleasure. Thank you and the other reviewers for your work! Bests, -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
