> -----Message d'origine----- > De : Eric Blake [mailto:[email protected]] > Envoyé : vendredi 10 octobre 2014 15:02 > À : Yves Vinter; [email protected] > Objet : Re: [libvirt] [PATCH 01/21] Added missing virBufferFreeAndReset on > the query buffer to free some memory > > On 10/10/2014 07:00 AM, Eric Blake wrote: > > >> Right; there are potential paths through which the query buffer may > be not released (in hypervEnumAndPull). > > > > Not if you take my alternate proposed 1/21 patch. > > > >> For safety, I systematically added this line for any local virBuffer > variable. > > > > I'd rather fix the one function than have to fix every caller. > > > > Hmm, did you even see my alternative proposal? I may have forgotten to cc > you:
No I didn't. OK. I will test your alternative proposal; thanks. > > https://www.redhat.com/archives/libvir-list/2014-October/msg00284.html > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
