On 10/17/14 18:05, Maxime Leroy wrote:
> VIR_TEST_DEBUG=2 ./qemuxml2argvtest generates the following output:
> 
> 409) QEMU XML-2-ARGV shmem-invalid-size
> ... Got expected error: unsupported configuration: ivshmem device is not \
>        supported with this QEMU binary
> OK
> 410) QEMU XML-2-ARGV shmem-small-size
> ... Got expected error: unsupported configuration: ivshmem device is not \
> supported with this QEMU binary
> OK
> 
> We should have:
> 
> 409) QEMU XML-2-ARGV shmem-invalid-size
> ... Got expected error: XML error: shmem size must be a power of two
> OK
> 410) QEMU XML-2-ARGV shmem-small-size
> ... Got expected error: XML error: shmem size must be at least 1 MiB
> OK
> 
> This commit fixes the issue by providing QEMU_CAPS_DEVICE_IVSHMEM caps
> for shmem-invalid-size, shmem-small-size test.
> 
> Signed-off-by: Maxime Leroy <[email protected]>
> ---
>  tests/qemuxml2argvtest.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

Nice catch! ACK and pushed.

Thanks

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to