On Wed, Nov 12, 2014 at 4:07 AM, Michal Privoznik <[email protected]> wrote: > On 11.11.2014 16:35, Conrad Meyer wrote: >> +/* These are bit flags: */ >> +enum { >> + BHYVE_GRUB_CAP_CONSDEV = 0x00000001, >> +}; > > > I think this should be rather typedef enum {...} virBhyveGrubCapsFlags;
Ok. >> +int virBhyveProbeGrubCaps(unsigned *caps); > > > And hence s/unsigned/virBhyveGrubCapsFlags/ This seems like a confusing use of an enum to me — with 2+ flags, you can return values that are no longer present in the enum as enum type. > >> + >> #endif >> > > I'm fixing this and pushing. ACK. Thanks, Conrad -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
