On 03/26/2015 04:24 PM, Peter Krempa wrote:
On Thu, Mar 26, 2015 at 14:30:56 +0800, Luyao Huang wrote:
When start a vm which have a memory device with address, the error
like this :
error: Failed to start domain test3
error: internal error: early end of file from monitor: possible problem:
2015-03-26T03:45:52.338891Z qemu-kvm: -device pc-dimm,node=0,memdev=memdimm0,
id=dimm0,slot=0,base=4294967296: Property '.base' not found
After check the qemu code i think this 'base' should named as 'addr',
you can see this mail:
http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00129.html
Or check the include/hw/mem/pc-dimm.h in qemu source.
Also add a tests for this.
Signed-off-by: Luyao Huang <lhu...@redhat.com>
---
I didn't change this parameter's name ('base'), because i am not sure
if there is some special mean in it, or it is a result after
discuss.
You are right, the "base" address has to be formatted as "addr".
src/qemu/qemu_command.c | 2 +-
.../qemuxml2argv-memory-hotplug-dimm-addr.args | 9 +++++
.../qemuxml2argv-memory-hotplug-dimm-addr.xml | 45 ++++++++++++++++++++++
tests/qemuxml2argvtest.c | 2 +
4 files changed, 57 insertions(+), 1 deletion(-)
create mode 100644
tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-dimm-addr.args
create mode 100644
tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-dimm-addr.xml
I've reworded the commit message and pushed this patch.
Thanks for your quick review.
Peter
Luyao
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
