On Tue, Jan 20, 2009 at 09:20:24PM +0000, Daniel P. Berrange wrote: > On Tue, Jan 20, 2009 at 10:18:31PM +0100, Daniel Veillard wrote: > > On Tue, Jan 20, 2009 at 08:36:27PM +0100, Daniel Veillard wrote: > > > On Tue, Jan 20, 2009 at 11:14:03AM -0800, [email protected] wrote: > > > > It cannot be freed, as it's used by reference in the syslog code, at > > > > least on Solaris. > > > > > > The requirement is apparently not present on Linux, sorry :-) > > > > > > I would prefer to keep the reference around and not leak it for > > > example on reloads > > > > Another version with an extra strdup but making clearer what > > the change do and fixing the closelog/free order, > > > > if tested positively please apply, thanks ! > > ACK, I like this version
Okay I pushed after John ACK'ed on IRC too, thanks, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ [email protected] | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
