On Mon, Jun 08, 2015 at 12:58:06 +0200, Michal Privoznik wrote:
> Not every architecture out there has 'char' signed by default.
> For instance, my arm box has it unsigned by default:
> 
>   $ gcc -dM -E - < /dev/null | grep __CHAR_UNSIGNED__
>   #define __CHAR_UNSIGNED__ 1
> 
> Therefore, after 65c61e50 the test if failing for me. Problem is,
> we are trying to assign couple of negative values into char
> assuming some will overflow and some don't. That can't be the
> case if 'char' is unsigned by default. Lets use more explicit types
> instead: int8_t and uint8_t where is no ambiguity.
> 
> Signed-off-by: Michal Privoznik <mpriv...@redhat.com>
> ---
>  tests/utiltest.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

ACK,

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to